Return iterable of RegExpExecArray from RegExp#[Symbol.matchAll] by lionel-rowe · Pull Request #60516 · microsoft/TypeScript

lionel-rowe · 2024-11-16T09:26:07Z

jakebailey · 2025-07-01T00:10:48Z

typescript-bot · 2025-07-01T00:10:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-07-01T01:01:10Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,603k (± 0.02%)}	_{195,391k (± 0.94%)}	_~	_192,984k	_196,684k	_{p=0.298 n=6}
_{Parse Time}	_{1.61s (± 1.02%)}	_{1.61s (± 1.29%)}	_~	_1.58s	_1.63s	_{p=0.935 n=6}
_{Bind Time}	_{0.87s (± 1.39%)}	_{0.88s (± 0.85%)}	_~	_0.87s	_0.89s	_{p=0.240 n=6}
_{Check Time}	_{11.83s (± 0.53%)}	_{11.79s (± 0.71%)}	_~	_11.71s	_11.90s	_{p=0.298 n=6}
_{Emit Time}	_{3.30s (± 1.20%)}	_{3.27s (± 1.17%)}	_~	_3.22s	_3.33s	_{p=0.107 n=6}
_{Total Time}	_{17.61s (± 0.56%)}	_{17.54s (± 0.43%)}	_~	_17.46s	_17.63s	_{p=0.423 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,753	_948,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,846	_410,846	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,260k (± 0.00%)}	_{1,225,262k (± 0.01%)}	_~	_1,225,164k	_1,225,355k	_{p=1.000 n=6}
_{Parse Time}	_{7.89s (± 0.97%)}	_{7.93s (± 1.10%)}	_~	_7.79s	_8.01s	_{p=0.471 n=6}
_{Bind Time}	_{2.29s (± 0.53%)}	_{2.29s (± 0.51%)}	_~	_2.28s	_2.31s	_{p=0.502 n=6}
_{Check Time}	_{37.92s (± 0.52%)}	_{38.13s (± 0.21%)}	_{+0.21s (+ 0.55%)}	_38.00s	_38.22s	_{p=0.045 n=6}
_{Emit Time}	_{17.89s (± 0.54%)}	_{17.89s (± 0.58%)}	_~	_17.70s	_17.98s	_{p=0.810 n=6}
_{Total Time}	_{65.99s (± 0.51%)}	_{66.23s (± 0.22%)}	_~	_66.04s	_66.46s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,509,183	_2,509,183	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,716	_892,716	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,804,468k (± 0.00%)}	_{2,804,432k (± 0.00%)}	_~	_2,804,307k	_2,804,619k	_{p=0.689 n=6}
_{Parse Time}	_{10.51s (± 0.20%)}	_{10.51s (± 0.29%)}	_~	_10.48s	_10.56s	_{p=0.935 n=6}
_{Bind Time}	_{2.73s (± 0.38%)}	_{2.73s (± 0.75%)}	_~	_2.70s	_2.75s	_{p=0.868 n=6}
_{Check Time}	_{101.91s (± 1.19%)}	_{101.71s (± 1.44%)}	_~	_100.51s	_104.55s	_{p=0.689 n=6}
_{Emit Time}	_{0.36s (± 1.50%)}	_{0.37s (± 2.41%)}	_~	_0.36s	_0.38s	_{p=0.341 n=6}
_{Total Time}	_{115.51s (± 1.03%)}	_{115.32s (± 1.27%)}	_~	_114.18s	_118.16s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,081	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,474	_267,474	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,853,321k (±13.24%)}	_{2,975,057k (±10.03%)}	_~	_2,365,324k	_3,098,031k	_{p=1.000 n=6}
_{Parse Time}	_{6.59s (± 1.70%)}	_{6.64s (± 1.27%)}	_~	_6.49s	_6.74s	_{p=0.378 n=6}
_{Bind Time}	_{2.16s (± 1.65%)}	_{2.17s (± 1.77%)}	_~	_2.13s	_2.24s	_{p=1.000 n=6}
_{Check Time}	_{42.85s (± 0.63%)}	_{42.84s (± 0.33%)}	_~	_42.62s	_42.97s	_{p=0.810 n=6}
_{Emit Time}	_{3.44s (± 4.87%)}	_{3.50s (± 2.27%)}	_~	_3.38s	_3.62s	_{p=0.296 n=6}
_{Total Time}	_{55.05s (± 0.66%)}	_{55.15s (± 0.35%)}	_~	_54.90s	_55.37s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,081	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,474	_267,474	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,918,825k (±12.88%)}	_{3,161,602k (± 0.02%)}	_~	_3,160,892k	_3,162,420k	_{p=0.575 n=6}
_{Parse Time}	_{8.43s (± 1.39%)}	_{8.54s (± 0.32%)}	_~	_8.49s	_8.57s	_{p=0.065 n=6}
_{Bind Time}	_{2.69s (± 1.80%)}	_{2.65s (± 0.75%)}	_~	_2.63s	_2.68s	_{p=0.258 n=6}
_{Check Time}	_{53.03s (± 0.41%)}	_{53.31s (± 0.54%)}	_~	_52.88s	_53.67s	_{p=0.128 n=6}
_{Emit Time}	_{4.43s (± 2.55%)}	_{4.31s (± 2.71%)}	_~	_4.20s	_4.51s	_{p=0.128 n=6}
_{Total Time}	_{68.61s (± 0.41%)}	_{68.82s (± 0.50%)}	_~	_68.25s	_69.16s	_{p=0.260 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,548	_262,548	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,156	_107,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,890k (± 0.01%)}	_{441,862k (± 0.01%)}	_~	_441,775k	_441,976k	_{p=0.298 n=6}
_{Parse Time}	_{3.55s (± 0.66%)}	_{3.56s (± 0.97%)}	_~	_3.52s	_3.61s	_{p=0.872 n=6}
_{Bind Time}	_{1.32s (± 0.88%)}	_{1.33s (± 0.79%)}	_~	_1.31s	_1.34s	_{p=0.800 n=6}
_{Check Time}	_{18.90s (± 0.33%)}	_{18.88s (± 0.35%)}	_~	_18.82s	_18.97s	_{p=0.630 n=6}
_{Emit Time}	_{1.54s (± 0.86%)}	_{1.53s (± 0.90%)}	_~	_1.51s	_1.54s	_{p=0.156 n=6}
_{Total Time}	_{25.31s (± 0.20%)}	_{25.30s (± 0.44%)}	_~	_25.19s	_25.44s	_{p=0.521 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,104k (± 0.00%)}	_{371,199k (± 0.04%)}	_{+95k (+ 0.03%)}	_371,117k	_371,531k	_{p=0.008 n=6}
_{Parse Time}	_{2.90s (± 0.44%)}	_{2.88s (± 0.87%)}	_~	_2.85s	_2.92s	_{p=0.224 n=6}
_{Bind Time}	_{1.61s (± 1.07%)}	_{1.60s (± 1.66%)}	_~	_1.57s	_1.64s	_{p=0.466 n=6}
_{Check Time}	_{16.36s (± 0.14%)}	_{16.37s (± 0.32%)}	_~	_16.29s	_16.43s	_{p=0.421 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{20.87s (± 0.18%)}	_{20.86s (± 0.28%)}	_~	_20.75s	_20.92s	_{p=0.809 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,499,334	_3,499,334	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,177,235	_1,177,234	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,549,909k (± 0.00%)}	_{3,549,720k (± 0.01%)}	_~	_3,549,461k	_3,549,972k	_{p=0.093 n=6}
_{Parse Time}	_{15.05s (± 0.75%)}	_{15.03s (± 0.55%)}	_~	_14.92s	_15.13s	_{p=0.520 n=6}
_{Bind Time}	_{4.90s (± 0.56%)}	_{4.90s (± 0.42%)}	_~	_4.86s	_4.92s	_{p=0.685 n=6}
_{Check Time}	_{98.60s (± 4.95%)}	_{96.16s (± 3.36%)}	_~	_93.76s	_101.66s	_{p=0.230 n=6}
_{Emit Time}	_{30.57s (± 2.94%)}	_{30.89s (± 4.28%)}	_~	_29.38s	_32.88s	_{p=0.689 n=6}
_{Total Time}	_{149.13s (± 3.76%)}	_{146.98s (± 2.64%)}	_~	_143.01s	_152.75s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_318,019	_318,019	_~	_~	_~	_{p=1.000 n=6}
_Types	_137,705	_137,704	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{472,238k (± 0.03%)}	_{472,120k (± 0.02%)}	_~	_471,967k	_472,281k	_{p=0.298 n=6}
_{Parse Time}	_{4.34s (± 0.32%)}	_{4.35s (± 0.57%)}	_~	_4.33s	_4.40s	_{p=0.677 n=6}
_{Bind Time}	_{1.78s (± 1.61%)}	_{1.77s (± 0.75%)}	_~	_1.75s	_1.78s	_{p=0.682 n=6}
_{Check Time}	_{20.75s (± 0.48%)}	_{20.66s (± 0.39%)}	_~	_20.54s	_20.74s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.87s (± 0.39%)}	_{26.78s (± 0.25%)}	_~	_26.67s	_26.84s	_{p=0.148 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_665,978	_665,978	_~	_~	_~	_{p=1.000 n=6}
_Types	_199,345	_199,345	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{570,437k (± 0.01%)}	_{570,349k (± 0.01%)}	_{-88k (- 0.02%)}	_570,247k	_570,411k	_{p=0.031 n=6}
_{Parse Time}	_{4.25s (± 0.53%)}	_{4.26s (± 0.49%)}	_~	_4.24s	_4.29s	_{p=0.328 n=6}
_{Bind Time}	_{1.33s (± 1.04%)}	_{1.32s (± 1.03%)}	_~	_1.30s	_1.34s	_{p=0.935 n=6}
_{Check Time}	_{19.92s (± 0.34%)}	_{19.90s (± 0.26%)}	_~	_19.86s	_19.97s	_{p=0.332 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.50s (± 0.24%)}	_{25.49s (± 0.24%)}	_~	_25.43s	_25.59s	_{p=0.629 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-07-01T01:04:32Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-07-01T01:07:23Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60516/merge:

Everything looks good!

typescript-bot · 2025-07-01T02:30:31Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60516/merge:

Everything looks good!

Copilot

Pull request overview

Aligns TypeScript’s lib typing for RegExp#[Symbol.matchAll] with the already-correct String#matchAll behavior by returning an iterator of RegExpExecArray (fixing #60515).

Changes:

Updated RegExp#[Symbol.matchAll] to return RegExpStringIterator<RegExpExecArray> instead of RegExpMatchArray.
Updated compiler test baselines to reflect the new iterator element type (including index/input becoming non-optional).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/baselines/reference/regexMatchAll.types	Baseline updated to show `RegExpExecArray` element type and required `index`/`input`.
tests/baselines/reference/regexMatchAll-esnext.types	Same baseline update for the `esnext` target test.
src/lib/es2020.symbol.wellknown.d.ts	Changes `RegExp#[Symbol.matchAll]` return type to `RegExpStringIterator<RegExpExecArray>`.

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 16, 2024

lionel-rowe force-pushed the regexp-symbol-matchall branch from 2fe6cd8 to 313b9d4 Compare November 16, 2024 10:18

Return iterable of RegExpExecArray from RegExp#[Symbol.matchAll]

11944f3

lionel-rowe force-pushed the regexp-symbol-matchall branch from 313b9d4 to 11944f3 Compare November 16, 2024 10:38

Merge branch 'main' into pr-60516

404f48a

typescript-bot removed the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 6, 2026

Copilot AI review requested due to automatic review settings February 6, 2026 22:05

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 6, 2026

Copilot started reviewing on behalf of jakebailey February 6, 2026 22:06 View session

jakebailey approved these changes Feb 6, 2026

View reviewed changes

jakebailey enabled auto-merge February 6, 2026 22:06

Copilot AI reviewed Feb 6, 2026

View reviewed changes

RyanCavanaugh approved these changes Feb 6, 2026

View reviewed changes

github-project-automation bot moved this from Not started to Needs merge in PR Backlog Feb 6, 2026

jakebailey added this pull request to the merge queue Feb 6, 2026

Merged via the queue into microsoft:main with commit 8bb72d2 Feb 6, 2026
28 of 29 checks passed

github-project-automation bot moved this from Needs merge to Done in PR Backlog Feb 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return iterable of RegExpExecArray from RegExp#[Symbol.matchAll]#60516

Return iterable of RegExpExecArray from RegExp#[Symbol.matchAll]#60516
jakebailey merged 2 commits intomicrosoft:mainfrom
lionel-rowe:regexp-symbol-matchall

lionel-rowe commented Nov 16, 2024

Uh oh!

jakebailey commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Jul 1, 2025

tsc

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lionel-rowe commented Nov 16, 2024

Uh oh!

jakebailey commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 1, 2025

tsc

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Jul 1, 2025 •

edited

Loading